On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov <[email protected]> wrote:

>> It was implemented in JetBrains Runtime a year ago and was ported & 
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or 
>> bilinear-mipmap style algorithms depending on the text antialiasing hint
>> - Storing BGRA glyphs in glyph cache & rendering them as plain images, as 
>> currently used XRender text drawing functions doesn't support colored glyphs
>> - Small fixes in related code like null-checks which could cause NPE & 
>> comment typos
>
> Nikita Gubarkov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix pointer to jlong conversion on x86

There are several options to resolve this problem without failing the tests:
- you can provide a diagnostic message, so passing for configurations missing 
necessary fonts won’t be silent
- create your own font with the necessary properties and submit it within the 
fix

-------------

PR: https://git.openjdk.org/jdk/pull/4798

Reply via email to