On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

> It seems Synth has two cases of updateStyle() where its argument is not 
> passed to the getContext() call. It seems to be an oversight as in other 
> Synth classes, the component argument passed to updateStyle is being passed 
> to getContext().
> 
> CI tests are ok with this change and there is no new regeression with CI 
> tests run in NimbusL&F by default..

I dont think there is any difference between passing method argument vis-a-vis 
this as I think both point to same object..
As I told, I dont see any difference in rendering with and without this 
change...
It is just to maintain consistency which is being done here or we could just 
close as "Wont fix"...but I think we should just give it a chance to have all 
the classes maintain the same construct...

-------------

PR: https://git.openjdk.org/jdk/pull/11875

Reply via email to