On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> It seems Synth has two cases of updateStyle() where its argument is not > passed to the getContext() call. It seems to be an oversight as in other > Synth classes, the component argument passed to updateStyle is being passed > to getContext(). > > CI tests are ok with this change and there is no new regeression with CI > tests run in NimbusL&F by default.. As they ought to. All UI classes assume that the source for the property listener is the component it is the delegate for, which is why we see some classes passing `e.getSource()` and others passing the protected field. It's not something we can test, because the issues will arise when *other* people invoke the listener, and the JDK code doesn't (seem to) directly call it. I'll plug #11892 because it would close the possibility for outsiders to poison the listener. ------------- PR: https://git.openjdk.org/jdk/pull/11875
