On Mon, 16 Jan 2023 14:20:30 GMT, Tejesh R <[email protected]> wrote: >> FileChooser Open/Approve button size is shown incorrectly when no Approve >> button text is set in `CUSTOM_DIALOG` type. Reason being that no default >> Approve Button text is returned during Dialog Type Property change. Since >> `null` is returned as Button string the Button size is incorrectly shown. >> The fix here addresses the issue by adding a default Approve Button Text >> when no text is set explicitly in case of `CUSTOM_DIALOG` type. >> Automated test is attached which has been tested with multiple test runs. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Added Aqua L&F - linked to #12008 fix
Marked as reviewed by aivanov (Reviewer). test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 38: > 36: * @key headful > 37: * @summary JFileChooser Test to check for FileChooser's Approve Button > Text > 38: * when CUSTOM_DIALOG type is set and check getDefaultButton() > (AquaL&F) Suggestion: * @summary Verifies JFileChooser's Approve button text is non-null * when CUSTOM_DIALOG type is set I'd remove reference to Aqua L&F, it's an unimportant detail in my opinion. ------------- PR: https://git.openjdk.org/jdk/pull/11901
