On Mon, 16 Jan 2023 14:57:33 GMT, Tejesh R <[email protected]> wrote: >> FileChooser Open/Approve button size is shown incorrectly when no Approve >> button text is set in `CUSTOM_DIALOG` type. Reason being that no default >> Approve Button text is returned during Dialog Type Property change. Since >> `null` is returned as Button string the Button size is incorrectly shown. >> The fix here addresses the issue by adding a default Approve Button Text >> when no text is set explicitly in case of `CUSTOM_DIALOG` type. >> Automated test is attached which has been tested with multiple test runs. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated JTREG summary
test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 71: > 69: frame.setVisible(true); > 70: > 71: JButton customApproveButton = > fileChooser.getUI().getDefaultButton(fileChooser); we should check the changes in getApproveButtonToolTipText and getApproveButtonMnemonic as well. ------------- PR: https://git.openjdk.org/jdk/pull/11901
