Re: [jdk20] RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF

[Prasanta Sadhukhan]

On Fri, 27 Jan 2023 02:40:27 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

> Fixes regression bug where Aqua L&F editable JComboBox with a TitledBorder 
> was not visible. 
> 
> This fix adds a conditional that addresses cases where a border is used on an 
> AquaComboBox. The patch that caused the issue set a static height, but this 
> height caused issues with a TitledBorder, which modifies the height to 
> account for the border. In this case, revert to the old method of calculating 
> a comboBox's height.
> 
> A point made in the previous PR was that the previous method had +1 to 
> comboBox height. This could be re-added, but in the comment thread in [the 
> previous PR](https://github.com/openjdk/jdk/pull/12087), leaving this out is 
> better because the extra height causes the textField to be skewed South.
> 
> <img width="63" alt="Screen Shot 2023-01-20 at 12 54 47 PM" 
> src="https://user-images.githubusercontent.com/96267980/214998560-2340ac1d-5df3-47ba-94f7-56459211330e.png";>
> 
> This also adds the test that checks an editable JComboBox across all L&F's 
> except GTK. There seems to be an unrelated bug to this fix that causes GTK 
> L&F comboBoxes to not behave as expected with these key presses.

test/jdk/javax/swing/JComboBox/JComboBoxWithTitledBorderTest.java line 76:

> 74:             // doesn't change text and resets to starting text instead.
> 75:             if (laf.equals("com.sun.java.swing.plaf.gtk.GTKLookAndFeel")) 
> {
> 76:                 return;

Guess it should be "continue" instead of "return" to ensure other L&Fs can 
execute..

Also, I hope you have run full clientlibs and manual JComboxBox jtreg tests 
without issues since it's past RDP2...
Did you also try with other "Border" other than TitledBorder?

-------------

PR: https://git.openjdk.org/jdk20/pull/119