On Fri, 27 Jan 2023 07:19:43 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change return to continue
>
> test/jdk/javax/swing/JComboBox/JComboBoxWithTitledBorderTest.java line 76:
>
>> 74: // doesn't change text and resets to starting text instead.
>> 75: if
>> (laf.equals("com.sun.java.swing.plaf.gtk.GTKLookAndFeel")) {
>> 76: return;
>
> Guess it should be "continue" instead of "return" to ensure other L&Fs can
> execute..
>
> Also, I hope you have run full clientlibs and manual JComboxBox jtreg tests
> without issues since it's past RDP2...
> Did you also try with other "Border" other than TitledBorder?
I agree, I updated this to "continue". I did run both the entire clientlibs
test and the individual test with a repeat of 5. I will re-run these tests with
the "continue" just in case this affects the results.
I tried locally with other Borders, such as LineBorder. The test still works
for this case.
-------------
PR: https://git.openjdk.org/jdk20/pull/119
