On Wed, 22 Feb 2023 00:02:10 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in >> a JButton in Aqua L&F. The new issue comes from having text inside the HTML >> as the button's text. If an icon is used, this icon exceeds the bounds of >> the button and overlaps the border. >> >> Added additional logic to check if HTML contains an img. If so, apply the >> previous fix. Otherwise, the original implementation for Aqua's JButton HTML >> layout works correctly, so use this behavior. >> >> Added a test based on the provided test in the bug report. Automated the >> test using a BufferedImage and changed the icon color to RED. Tested with >> multiple runs on Aqua L&F, and the test passes with the update where it >> fails without the update. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Remove redundant check and reuse var. Changes look good. ------------- Marked as reviewed by honkar (Committer). PR: https://git.openjdk.org/jdk/pull/12520
