> Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a > JButton in Aqua L&F. The new issue comes from having text inside the HTML as > the button's text. If an icon is used, this icon exceeds the bounds of the > button and overlaps the border. > > Added additional logic to check if HTML contains an img. If so, apply the > previous fix. Otherwise, the original implementation for Aqua's JButton HTML > layout works correctly, so use this behavior. > > Added a test based on the provided test in the bug report. Automated the test > using a BufferedImage and changed the icon color to RED. Tested with multiple > runs on Aqua L&F, and the test passes with the update where it fails without > the update.
Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Add reusable icon var. Update comment. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12520/files - new: https://git.openjdk.org/jdk/pull/12520/files/6e692450..e8a06771 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12520&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12520&range=03-04 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/12520.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12520/head:pull/12520 PR: https://git.openjdk.org/jdk/pull/12520
