On Mon, 24 Apr 2023 18:14:05 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add braces around if clause.
>
> test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 34:
>
>> 32: import java.util.HashSet;
>> 33:
>> 34: public class DefaultMethodBeanPropertyTest {
>
> Can we please add two additional tests to verify the "diamond" case:
> - getFoo is in the top interfaceA, two empty subinterfaces B anc C , and one
> class D of B and C, will the D have one correct prop Foo?
> - getFoo is in the top interfaceA, two non-empty subinterfaces B and C and
> each override getFoo by the different return types, and then one class D of B
> and C which override getFoo again by compatible type from B and C, will the D
> have one correct prop Foo?
>
> We also can test the case if the D from the cases above is interface and
> implemented by the class E.
Sure thing... see 6b43627f5f0.
> test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 78:
>
>> 76:
>> 77: // Expected properties
>> 78: final HashSet<PropertyDescriptor> expected = new HashSet<>();
>
> please split the long lines to use 80 chars per line.
Fixed in e6a2ecba589.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13544#discussion_r1175690195
PR Review Comment: https://git.openjdk.org/jdk/pull/13544#discussion_r1175693481
