On Tue, 25 Apr 2023 18:52:16 GMT, Archie Cobbs <aco...@openjdk.org> wrote:
>> The `Introspector` class was never updated to include `default` methods >> inherited from interfaces. >> >> This patch attempts to fix that omission. > > Archie Cobbs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 13 additional > commits since the last revision: > > - Whitespace cleanups suggested by review. > - Merge branch 'master' into JDK-8071693 > - Jam lines into 80 columns. > - Add more scenarios to the regression test. > - Add braces around if clause. > - Add comment describing what IGNORABLE_INTERFACES is for. > - Put braces around single-line "if" statement clauses in test. > - Merge branch 'master' into JDK-8071693 > - Verify static method is not mistakenly identified as property getter. > - Use Modifier.isAbstract() convenience method instead of bit masking test. > - ... and 3 more: https://git.openjdk.org/jdk/compare/a3bbc5eb...b92726a9 > As a retroactive post-integration comment, there is judgement required when gauging whether or not the behavioral changes associated with a PR merit a CSR, as discussed in the CSR FAQ: "Q: Under what conditions does a CSR need to be filed for a purely behavioral change? A: Using qualitative terms, a CSR for a behavioral change should be filed if it is estimated enough developers or users would be sufficiently impacted by the change that it should get additional consideration or documentation. A judgment call is involved. If assistance is needed in determining whether or not a CSR needs to be filed, ask the CSR representative for that area or the CSR chair." https://wiki.openjdk.org/display/csr/CSR+FAQs Given my general understanding of the nature of the change, based on nature of the change, my answer to the question of whether or not this should have a CSR would be "yes", but I'm happy to defer to @prrace 's subject matter expertise here that the answer should be "no." ------------- PR Comment: https://git.openjdk.org/jdk/pull/13544#issuecomment-1524142980
