On Thu, 11 May 2023 06:37:22 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Shift and Control mask modified > > test/jdk/javax/swing/JMenuItem/bug4966168.java line 26: > >> 24: /* @test >> 25: @bug 4966168 >> 26: @summary JInternalFrame not serializable in Motif & GTK L&F > > I dont see the test being tested for Motif & GTK which are not default > L&F...Probably we should iterate for all L&F just to be sure.. > Also, all `throw new Error` should ideally be changed to `throw new > RuntimeException` for all tests in this PR.. After modifying the test to run in all L&F, CI failure observed for linux and linux-aarch machine with the exception `javax.swing.UnsupportedLookAndFeelException: [GTK look and feel - com.sun.java.swing.plaf.gtk.GTKLookAndFeel] not supported on this platform`. On my local machine (Oracle Linux) test passed for all LAFs. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190842678
