On Thu, 11 May 2023 10:02:03 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> This PR is to open source JMenuItem related swing tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Check for all LAFs
test/jdk/javax/swing/JMenuItem/bug4966168.java line 63:
> 61: } catch (Exception e) {
> 62: System.out.println("Look and Feel not set: " +
> laf.getClassName());
> 63: continue;
It should be only for UnsupportedLookAndFeelException...other Exception should
fail the test..
test/jdk/javax/swing/JMenuItem/bug4966168.java line 70:
> 68: } catch (Exception e) {
> 69: throw new RuntimeException(e);
> 70: }
guess no need of try-catch..if there are exceptions, let it fail with original
Exception
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190941968
PR Review Comment: https://git.openjdk.org/jdk/pull/13822#discussion_r1190942016
