On Mon, 22 May 2023 09:51:12 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> I was not sure how to get the other value which is told in the spec where it > says percentage needs another value to be passed in. Also checking for > percentage equality resulted in regression in one closed test bug4690812.java > so percentage equality was not handled. > > https://github.com/openjdk/jdk/blob/8aa50288a1a6a853bf4d8d97b1849d5744ed7a32/src/java.desktop/share/classes/javax/swing/text/html/CSS.java#L2607-L2609 I don't think you need to. In this case, AttributeSets are compared. All the relative units will result in different computed value depending on the element they're applied to. I'll take a look at the test. I can't see how implementation of `equals` affects that test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1200345789
