On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> added displayChanged call to CPlatformWindow when frame first needs to 
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   use realsync to flush native queue

@alisenchung 

The current fix works for the cases listed in the test but fails for the 
following scenarios. To make the test more stable it is better to reassign the 
static variable `lastFrameState = Frame.NORMAL` in examineStates after creating 
a new Frame [here 
](https://github.com/openjdk/jdk/blob/57b8251241e2044d5039ce162bf4637a9b2e5466/test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java#L78),
 so that each time a new case is run it sets lastFrameState to default state.


// CASE 1:
examineStates(new int[] {Frame.NORMAL, Frame.MAXIMIZED_BOTH, Frame.ICONIFIED});
// CASE 2:
examineStates(new int[] {Frame.NORMAL, Frame.ICONIFIED, Frame.MAXIMIZED_BOTH});

-------------

Changes requested by honkar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14226#pullrequestreview-1480046670

Reply via email to