On Wed, 14 Jun 2023 20:35:14 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> I don't like the idea of a delay in either of the ways discussed here. >> And although I do think that its much better to wait for delivery of an >> event, I'm not sure I understand the windowState listener proposal. >> How do you know in this code that the transition of >> iconified-> normal will then followed by normal->maximised ? >> Perhaps you'll wait for ever ? >> But I don't know what the macOS native model is for all of this. >> This sequence is kind of odd and I'm curious what happens on older macOS >> releases - Sergey touched on this but I don't see direct followup. >> There seems to be assumptions it was like this previously but now it is >> slower ? >> >> I suggest explicit verification of what happens on macOS 12.6. >> Are we now getting two native events when there used to be only one ? > >> I don't like the idea of a delay in either of the ways discussed here. And >> although I do think that its much better to wait for delivery of an event, >> I'm not sure I understand the windowState listener proposal. How do you know >> in this code that the transition of iconified-> normal will then followed by >> normal->maximised ? > > The code here is trying to do a transition from iconified -> maximized, but > splits it up into iconified -> normal and normal -> maximized. > @alisenchung The fix looks OK. Did you test it on macOS 12? If not, can you > ensure that previous macOS version(s) works fine with the proposed changes? I've tested on macOS12 and it works fine with the changes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14226#issuecomment-1611938229
