On Fri, 23 Jun 2023 17:57:16 GMT, Alisen Chung <[email protected]> wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added suggested changes
The update fix - with the current state check before acquiring the lock and
removing the WindowStateListener suggested by @dmarkov20 avoids unnecessary
acquiring of lock and looks to be a better solution that before.
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 970:
> 968:
> 969: private void waitForWindowState(int state) {
> 970: if(peer.getState() == state) {
Add a space after if
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 993:
> 991: }
> 992: }
> 993:
Minor nit: Remove extra line
test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 121:
> 119: System.out.println("------");
> 120: examineStates(new int[] {Frame.ICONIFIED, Frame.MAXIMIZED_BOTH,
> Frame.NORMAL});
> 121:
@alisenchung Now that the `lastFrameState` is fixed, I would suggest adding the
cases mentioned
[here](https://github.com/openjdk/jdk/pull/14226/files#r1237259547) too, to
make the test comprehensive.
-------------
PR Review: https://git.openjdk.org/jdk/pull/14226#pullrequestreview-1495733089
PR Review Comment: https://git.openjdk.org/jdk/pull/14226#discussion_r1240194617
PR Review Comment: https://git.openjdk.org/jdk/pull/14226#discussion_r1240192496
PR Review Comment: https://git.openjdk.org/jdk/pull/14226#discussion_r1240211363
