On Mon, 24 Jul 2023 18:16:21 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test changes: added CountDownLatch
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 107:
>
>> 105: if (!testStarted) {
>> 106: throw new RuntimeException("Test Failed: Manual test
>> timed out!!");
>> 107: }
>
> Suggestion:
>
> if (!countDownLatch.await(2, TimeUnit.MINUTES)) {
> throw new RuntimeException("Test Failed: Manual test
> timed out!!");
> }
> }
>
> If `await` timed out, the user didn't click the Start button.
>
> Thus, `testStarted` becomes redundant.
Updated.
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 245:
>
>> 243: private static void createTestUI() {
>> 244: String mode = isManual ? "MANUAL" : "AUTOMATED";
>> 245: jFrame = new JFrame("RobotModifierMaskTest - Mode: " + mode);
>
> Should you dispose of the instruction frame in the manual mode?
Added try & finally block for instruction frame.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1272848182
PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1272848955
