On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews <d...@openjdk.org> wrote:
>> 1) Used builder pattern
>> 2) Tested AWT tests and it passed
>
> lawrence.andrews has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Changed enableScreenCapture method name to screenCapture shorter method
> name
> - Update full name
Changes requested by honkar (Committer).
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 182:
> 180: InvocationTargetException {
> 181: this(builder.title, builder.instructions, builder.testTimeOut,
> 182: builder.rows, builder.columns,
> builder.enableScreenCapture);
`builder.enableScreenCapture` - need to update here as well in case you decide
to rename the boolean variable.
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 581:
> 579: private int rows;
> 580: private int columns;
> 581: private boolean enableScreenCapture = false;
@lawrence-andrew you missed updating var `enableScreenCapture` to
`screenCapture` here. You can either update only the method name to
screenCapture() and retain same var name (`enableScreenCapture`) or update two
other places where they are being used.
-------------
PR Review: https://git.openjdk.org/jdk/pull/14094#pullrequestreview-1570548332
PR Review Comment: https://git.openjdk.org/jdk/pull/14094#discussion_r1289195917
PR Review Comment: https://git.openjdk.org/jdk/pull/14094#discussion_r1289193963
