On Wed, 9 Aug 2023 21:02:37 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> lawrence.andrews has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Changed enableScreenCapture method name to screenCapture shorter method >> name >> - Update full name > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 581: > >> 579: private int rows; >> 580: private int columns; >> 581: private boolean enableScreenCapture = false; > > @lawrence-andrew you missed updating var `enableScreenCapture` to > `screenCapture` here. You can either update only the method name to > screenCapture() and retain same var name (`enableScreenCapture`) or update > two places where they are being used. They had the same name; Java allows the same name for a field and a method. For consistency with other methods and fields, I agree with @honkar-jdk and I'm for renaming it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14094#discussion_r1289886254
