On Thu, 21 Sep 2023 22:00:27 GMT, Alisen Chung <ach...@openjdk.org> wrote:
> Opening closed tests:
> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
> 15 javax/swing/plaf/metal/4306431/bug4306431.java
Changes requested by honkar (Committer).
test/jdk/javax/swing/ToolTipManager/bug5078214.java line 77:
> 75: }
> 76:
> 77: if (testGraphics != null) {
I agree with @aivanov-jdk on this
[point](https://github.com/openjdk/jdk/pull/15875/files#r1334325660). The
following condition can be checked first and the SkippedException can be added
here so as to return at this point if test conditions are not met.
Suggestion:
if (testGraphics == null) {
-------------
PR Review: https://git.openjdk.org/jdk/pull/15875#pullrequestreview-1640666079
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1334832378
