On Thu, 28 Sep 2023 17:10:39 GMT, Phil Race <p...@openjdk.org> wrote:
>>> Since this isn't a test for applet I think we should keep it for now >> >> What do you mean? >> >> All the test does is it verifies the `installComponents` method is >> accessible in a subclass of `BasicMenuItemUI`. The >> [`installComponents`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/plaf/basic/BasicMenuItemUI.html#installComponents(javax.swing.JMenuItem)) >> method is protected since JDK 1.3, it's now a public API. Removing it >> requires a CSR. >> >> Can it be accidentally removed? Can it be accidentally made package-private >> or private? *Very unlikely.* Therefore, we can save time by not running this >> test. > > the comment about applet is a bit out of context. Its from a comment I made > off-line that if you were taking > a test that was written as an Applet and it explicitly a test for applets, > that would be a good example of > a test to drop since JDK 22 doesn't support Applets, even thought the API is > still there. > > In this case, I agree I would not have bothered porting this test that > basically corresponds to the signature tests, > but its also harmless, notwithstanding the very tiny cost of running this as > a (now) headless test. > But since it was already done, I think we can keep it. It is a thousand times > better than it was before in its old form. Thank you for clarification. Let's keep it then. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1340468384
