On Mon, 4 Dec 2023 20:52:28 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test update > > test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java > line 143: > >> 141: createAndShowUI(); >> 142: fileChooser.setCurrentDirectory(testDir); >> 143: }); > > `fileChooser.setFileSelectionMode` that you call below should be called on > EDT, I suggest moving it into this block. > > This applies to all `check-*` methods. To eliminate duplicating code for disposing of the frame, create a helper method and call it from the `finally` block. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1414483436
