On Tue, 5 Dec 2023 12:12:34 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> To eliminate duplicating code for disposing of the frame, create a helper 
>> method and call it from the `finally` block.
>
>> `fileChooser.setFileSelectionMode` that you call below should be called on 
>> EDT, I suggest moving it into this block.
>> 
>> This applies to all `check-*` methods.
> 
> Accessed on EDT.

> To eliminate duplicating code for disposing of the frame, create a helper 
> method and call it from the `finally` block.

Updated, looks cleaner code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16674#discussion_r1415503842

Reply via email to