On Tue, 5 Dec 2023 18:18:53 GMT, Damon Nguyen <[email protected]> wrote:
>> The initial issue was a padding issue for JButton when HTML content was set >> as the button's text. >> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772), >> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and >> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are the issues >> related to the fix. The initial bug report was for Metal L&F, since it has a >> drastically different button margin from the rest (2, 14, 2, 14). This left >> and right margin of 14px led to the initial bug report. However, it was >> determined that the issue was not an issue, and instead, a problem with the >> reporter's implementation since they weren't aware of the difference in >> Metal's button margins versus other L&Fs. >> >> This PR reverts these changes since it was determined in [this >> PR](https://github.com/JFormDesigner/FlatLaf/issues/746) that the fix causes >> a new issue regarding JButton contents' positioning. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Re-add test because still valid > @DamonGuy Reverted changes fixes the issue. Since you are reverting #12520, > shouldn't the corresponding test HtmlButtonWithTextAndIcon.java be reverted > too? Copyright years need to be updated for some files. Alexander brought up the same question. After discussion, we decided to keep the test. The test is still valid & passes, so we could leave it in. I also have updated the copyright year for BasicButtonUI. I believe that's the only case of copyright years that needs to be updated. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16869#issuecomment-1841450104 PR Comment: https://git.openjdk.org/jdk/pull/16869#issuecomment-1841453725
