On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung <[email protected]> wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> also updated to remove applet usage and use PassFailJFrame instead.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> used jtreg.SkippedException, updated copyright years
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest.java line 49:
> 47: public static void main(String[] args) throws Exception {
> 48: boolean traySupported = SystemTray.isSupported();
> 49: if (!traySupported) {
Suggestion:
if (!SystemTray.isSupported()) {
The local variable is redundant.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17329#pullrequestreview-1822226261
PR Review Comment: https://git.openjdk.org/jdk/pull/17329#discussion_r1452725453
