On Sat, 27 Jan 2024 05:57:51 GMT, Alisen Chung <[email protected]> wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but >> the TrayIcon was already removed by the test, causing an error. The fix is >> to make SunToolkit skip posting the event if appContext is null. The test is >> also updated to remove applet usage and use PassFailJFrame instead. > > Alisen Chung has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk into 8316931 > - remove null check in SunToolkit, remove setting target to null in CTrayIcon > - Merge branch 'master' of https://github.com/openjdk/jdk into 8316931 > - added suggested changes, moved test back into folder > - added suggested changes, moved test back into folder > - used jtreg.SkippedException, updated copyright years > - removed extra newlines, moved test out of folder > - spacing > - updated test title, copyright year, removed redundant check > - removed applet usage in test, fixed event posted on wrong app context bug src/java.desktop/macosx/classes/sun/lwawt/macosx/CTrayIcon.java line 176: > 174: > 175: LWCToolkit.targetDisposedPeer(target, this); > 176: // target = null; Why do you commented out this line? just delete it and mark the target as final. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17329#discussion_r1474034815
