On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >> >> - Extracted the rendered text into a constant to ensure the same text is >> printed and displayed in the instructions. >> - Displayed an error message to the tester if `PrinterException` is caught >> and automatically failed the test. > > Alexey Ivanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Merge 8294148-splitUI > - Revert the condition in print() > - Update copyright year > - Handle PrinterException > - Ensure the same text is printed and displayed in the instructions > - 8325762: Use split UI for PrintLatinCJKTest test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 80: > 78: JOptionPane.ERROR_MESSAGE); > 79: PassFailJFrame.forceFail(msg); > 80: } > Displayed an error message to the tester if PrinterException is caught and > automatically failed the test. With the earlier test this failure was hidden until test timeouts and easy to miss, this code to handle PrinterException and forceFail the test immediately is a good addition. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17847#discussion_r1490139871
