On Fri, 23 Feb 2024 12:09:14 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a >> single *Print* button as its test UI. To simplify the UI, I used the new >> `splitUI` method from #17845. >> >> In addition to it, I refactored the test: >> >> - Extracted the rendered text into a constant to ensure the same text is >> printed and displayed in the instructions. >> - Displayed an error message to the tester if `PrinterException` is caught >> and automatically failed the test. > > Alexey Ivanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 16 commits: > > - Fail the test if there's no printer > > Amend instructions: remove warning about printer, > clarify what is expected. > - Use Font.DIALOG constant > - Merge master > - Merge 8294148-splitUI > - Revert changes to PrintLatinCJKTest > > The test to be updated separately. > - Revert the condition in print() > - Update copyright year > - Handle PrinterException > - Ensure the same text is printed and displayed in the instructions > - 8325762: Use split UI for PrintLatinCJKTest > - ... and 6 more: https://git.openjdk.org/jdk/compare/11fdca06...d5e3cb17 Marked as reviewed by honkar (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/17847#pullrequestreview-1904395301
