On Thu, 15 Feb 2024 02:10:22 GMT, Alexander Zvegintsev <[email protected]> wrote:
>> Well, clearly the exec will take some non-zero time, but this part of >> initialising the SystemTray only happens once and (arm-waving alert) 99% of >> apps don't do it at all, so I don't see it as a major problem and it needs >> to be done. >> There's a plan to re-do it with an API call later but that is more complex >> code than we have time for now, so it will be fine as a temporary solution. > > According to my tests, the call to `getGnomeShellMajorVersion()` took about > 25-35 ms on average, but it is a one-time task. > (arm-waving alert) 99% of apps don't do it at all, That may not be so arm-wavy actually considering this has been a problem for a while and we haven't exactly been inundated with complaints, especially since on RH & (I think) Fedora distros SystemTray isn't supported anyway unless you install gnome-shell-extensions. But hmm .. there's a thought - so long as available returns false anyway (via the existing code) do we even need to make this call ? Might need to be careful about when/whether the selectionListener is added. Alexander can you look at that to see if we can just not bother with the exec if it isn't going to be needed anyway ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17860#discussion_r1490283265
