On Thu, 15 Feb 2024 03:29:39 GMT, Phil Race <[email protected]> wrote:
>>> Latest comment from Phil related to not disabling SystemTray for Gnome>=45 >>> needs to be taken care. >> >> With the current version string format, this should not happen unless the >> executable is somewhere else, environment variables are stripped, etc. >> >> However, since this is a quick fix, a more reliable way to do this will be >> done along with [JDK-8325914](https://bugs.openjdk.org/browse/JDK-8325914). >> >> >>> Also do we need to worry about this issue being regression from some Gnome >>> version like 3.38.0 and we need to disable SystemTray only between 3.38.0 & >>> < 45 Or we are okay with disabling it for all version less than 45? >> >> The 3.38.0 was just an example of a different numbering convention, I can >> reproduce the issue on the 3.28.3 on OL7.9. So the lower limit is not known >> yet. So this is intentional, as an urgent fix. > > PS for context, one possibility strongly considered was to disable it > EVERYWHERE, regardless of version. Yes i know 3.38.0 was just an example i used. I was coming from the perspective of "Are we okay with disabling SystemTray for all versions <45 irrespective of whether SystemTray might work in some earlier version?". With latest comments in PR i see that we are okay with disabling for all <45 since it is a temporary urgent fix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17860#discussion_r1490334405
