On Wed, 20 Mar 2024 09:27:59 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Few closed manual applet tests are converted to main based and opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Frame title test/jdk/javax/swing/JFrame/bug4419914.java line 31: > 29: * @build PassFailJFrame > 30: * @run main/manual bug4419914 > 31: */ In most of the test which we are converting to main, we are moving the jtreg tags after imports. You are planning to retain it before imports? test/jdk/javax/swing/text/bug4148489.java line 31: > 29: * @build PassFailJFrame > 30: * @run main/manual bug4148489 > 31: */ One space gap. test/jdk/javax/swing/text/html/StyleSheet/bug4803145.java line 42: > 40: import javax.swing.text.html.HTMLEditorKit; > 41: > 42: Extra line space here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531765711 PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531760308 PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531768785
