On Wed, 20 Mar 2024 23:05:34 GMT, Phil Race <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> REview update > > test/jdk/javax/swing/JFrame/bug4419914.java line 71: > >> 69: frame.enableInputMethods(false); >> 70: >> frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT); >> 71: frame.getContentPane().setLocale(Locale.ENGLISH); > > The requirement to use getContentPane() has been obsolete since JDK 1.5 ... > here's an external page about it > https://coderanch.com/t/345686/java/getContentPane > But I don't generally tell people to delete except here there are 9 calls > cluttering up this code. > So not critical, but a suggestion. Thanks for the information, didn't know that..Updated....there is around ~400 occurrence of getContentPane() in swing tests in open still so probably something to be optimised in future... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533196007
