On Fri, 22 Mar 2024 07:02:05 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:
>
>> 40: public class bug4385611 {
>> 41: static JButton bt1, bt2;
>> 42: static final ImageIcon icon32x32 = new
>> ImageIcon(bug4385611.class.getResource("red.gif"));
>
> did you verify if we are allowed to keep this red.gif in open source as per
> the image license? Can we not create the Imageicon from a yellow32x32
> bufferedimage?
It is just a gif file filled with yellow color created specifically for that
test. It was not provided by the test submitter or anything like that - it was
just created in the graphics editor. There's no copyright issue with it.
> test/jdk/javax/swing/plaf/motif/bug4150591.java line 40:
>
>> 38: public class bug4150591 {
>> 39: public static void main(String[] args) {
>> 40: MotifInternalFrameTitlePane mtp = new
>> MotifInternalFrameTitlePane(new JInternalFrame());
>
> Is this test required to be added now with motif being deprecated?
It is deprecated but still exist. When we will decide to remove it (if we do at
some point) the test will be easily to delete since it is in the PLaF specific
test directory. I see no harm in keeping it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536249258
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536250007
