On Mon, 25 Mar 2024 16:24:10 GMT, Alexander Zuev <[email protected]> wrote:
>> Clean up and opensource five tests.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing image file as not needed, generating ImageIcon instead;
> Moved test file from the dedicated folder siince it is no longer needed;
> Removed setVidible(false) calls before disposal of the components;
Marked as reviewed by prr (Reviewer).
test/jdk/javax/swing/JButton/bug4385611.java line 84:
> 82: }
> 83: } catch (Exception e) {
> 84: e.printStackTrace();
Not a blocker for approval, but I wonder why this test catches the exception ?
Surely we don't expect installing the L&F to fail since we require windows.
And the Metal case above should never fail.
Perhaps we should let the exceptions propagate so the test fails rather than
being silent.
You decide.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18443#pullrequestreview-1958810958
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1538257423
