On Wed, 22 May 2024 02:25:14 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
> These changes are intended to stabilize testing on Wayland in X11
> compatibility mode.
>
> <hr>
>
> Many tests may fail if there is no `robot.delay()` call after
> `robot.waitForIdle()` (right after displaying a window).
> <hr>
>
> Some tests do not release previously pressed mouse button/key, this leads to
> other test failures later, but it is not a problem for X11 session.
> I haven't checked this, but it looks like the XWayland server does not
> release the key/button emulated by XTEST when the client application
> disconnects, while the regular X11 server does.
>
> <hr>
>
> For some tests it is critical to call AWT code on EDT(it prevents NPE):
> java/awt/List/KeyEventsTest/KeyEventsTest.java
> java/awt/Paint/ListRepaint.java
>
> <hr>
>
> Some other explanations can be found inline in the comments for a specific
> test.
> <hr>
>
> Testing is green on all platforms.
test/jdk/javax/swing/JButton/PressedButtonRightClickTest.java line 97:
> 95: // Test whether the button is still pressed
> 96: boolean pressed = myButton.getModel().isPressed();
> 97: System.out.println("release BUTTON1_DOWN_MASK");
Is this a debugging left over ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19339#discussion_r1610633132
