On Wed, 22 May 2024 21:52:14 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

>> These changes are intended to stabilize testing on Wayland in X11 
>> compatibility mode.
>> 
>> <hr>
>> 
>> Many tests may fail if there is no `robot.delay()` call after 
>> `robot.waitForIdle()` (right after displaying a window).
>> <hr>
>> 
>> Some tests do not release previously pressed mouse button/key, this leads to 
>> other test failures later, but it is not a problem for X11 session.
>> I haven't checked this, but it looks like the XWayland server does not 
>> release the key/button emulated by XTEST when the client application 
>> disconnects, while the regular X11 server does.
>> 
>> <hr>
>> 
>> For some tests it is critical to call AWT code on EDT(it prevents NPE):
>> java/awt/List/KeyEventsTest/KeyEventsTest.java
>> java/awt/Paint/ListRepaint.java
>> 
>> <hr>
>> 
>> Some other explanations can be found inline in the comments for a specific 
>> test.
>> <hr>
>> 
>> Testing is green on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   typo

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19339#pullrequestreview-2072672430

Reply via email to