On Sun, 26 May 2024 22:40:29 GMT, Phil Race <[email protected]> wrote:

>> Alexander Scherbatiy has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Move jtreg tags below the imports in the tests
>
> I'd like to have at least Prasanta and myself "approve" this hence
> 
> 
> @AlexanderScherbatiy please note that if you get one approval and have 
> resolved all issues and believe it just needs the 2nd reviewer to formally 
> approve it that the integrate command has some useful options
> https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate

@prrace 
The automated `CheckSupportedOutputBinsTest` is added which works on all 
platforms and checks that methods 
`PrintService.isAttributeCategorySupported(OutputBin.class)`, 
`PrintService.getDefaultAttributeValue(OutputBin.class)`, and 
`PrintService..getSupportedAttributeValues(OutputBin.class,...)` returns 
consistent results.

It has been tested on Linux, MacOS, and Windows with several installed printers.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2133841197

Reply via email to