On Sun, 26 May 2024 22:40:29 GMT, Phil Race <[email protected]> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move jtreg tags below the imports in the tests > > I'd like to have at least Prasanta and myself "approve" this hence > > > @AlexanderScherbatiy please note that if you get one approval and have > resolved all issues and believe it just needs the 2nd reviewer to formally > approve it that the integrate command has some useful options > https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate @prrace @prsadhuk The `OutputBinAttributePrintDialogTest` tests both common and native dialogs now. Actually the native dialog test works on MacOS only if the native print dialog includes Finishing Options with the list of output bins. It may or may not work if the output bins are placed on the separate Print Panel or in another place. It just because the native print dialog which includes Finishing Options stores the selected output bin with the `OutputBin` key in the NSPrintInfo print settings while other native print dialogs may not store the selected output bin in the NSPrintInfo print settings. May be it is better to split the `OutputBinAttributePrintDialogTest` test to common (`OutputBinAttributeCommonPrintDialogTest`) and native (`OutputBinAttributeNativePrintDialogTest`) tests and ask to skip the native test if the native print dialog does not include Finishing Options with the list of the output bins? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2133859482
