On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar <[email protected]> wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>> and then toggles between show/hide on `ALT` press.
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the
>> native behavior. Fix is similar to the `ALT` key processing in Windows LAF.
>> Automated test case is added to verify the fix and tested in Ubuntu and
>> Oracle linux.
>>
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> condition check update
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
line 769:
> 767: */
> 768: static void repaintMnemonicsInContainer(final Container cont) {
> 769: for (int i = 0; i < cont.getComponentCount(); i++) {
i think you can use `final Component c : cont.getComponents()` here the same
way you did in the repaintMnemonicsInWindow method
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621372299
