On Fri, 10 May 2024 05:48:35 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1085:
>>
>>> 1083: if (UIManager.getBoolean("Button.showMnemonics")) {
>>> 1084: // Do not hide mnemonics if the UI defaults do not
>>> support this
>>> 1085: isMnemonicHidden = false;
>>
>> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
>> only be done on the set method?
>
>> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
>> only be done on the set method?
>
> `isMnemonicHidden` is set to false to make sure if the UI defaults don't
> support to hide mnemonics, then don't hide it.
if the UI defaults don't support hiding mnemonics, should a warning be given to
the user?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1621383788
