On Wed, 24 Jul 2024 04:35:36 GMT, Abhishek Kumar <[email protected]> wrote:
>> test/jdk/javax/swing/JColorChooser/Test6977726.java line 46: >> >>> 44: Test passes if the panel is as described, test fails >>> otherwise. >>> 45: >>> 46: Note: "Preview" title is not applicable for GTK Look >>> and Feel."""; >> >> The test summary says it tests `setPreviewPanel`...if it's not present in >> native, then the full test is not applicable for GTK..I guess you can check >> for UIManager.getLookAndFeel() is GTK, then bail out.. > >> The test summary says it tests `setPreviewPanel`...if it's not present in >> native, then the full test is not applicable for GTK.. > > Actually the PreviewPanel is added for all L&F in JDK implementation in > BasicColorChooserUI ( see here > [L147](https://github.com/kumarabhi006/jdk/blob/70f3e99016311a6520e6a7c0da4c7ff718364976/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java#L147) > and > [L365](https://github.com/kumarabhi006/jdk/blob/70f3e99016311a6520e6a7c0da4c7ff718364976/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java#L365) > ). > > So, `setPreviewPanel` should be ok for GTK as well. ok...in that case please add a comment in the test citing "ColorChooser.showPreviewPanelText", Boolean.FALSE for GTKLookAndFeel because of which it is not applicable, in case we need to revisit this in future, although it does not make sense that preview panel is supported but not preview panel text, but let's maintain status-quo and not change product property just because of recently-modified internal test ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1689177040
