On Wed, 24 Jul 2024 06:28:03 GMT, Abhishek Kumar <[email protected]> wrote:
>> This test was modified under >> [JDK-8328403](https://bugs.openjdk.org/browse/JDK-8328403) bug to remove the >> applet usage. Test modification includes the instruction change as well >> which says that `Check that there is a panel with "Text Preview Panel" text >> and with title "Preview" in the JColorChooser`. Applet test didn't say >> explicitly about the panel title. >> >> When the test is run with `GTKLookAndFeel` option, `Preview` title is >> missing due to the `showPreviewPanelText` property defined for >> `GTKLookAndFeel` is set to **FALSE**. `showPreviewPanelText` property is not >> defined for other L&Fs and that leads to fallback to the default value of >> **TRUE** for the property while lookup. >> >> Proposed fix is to change the default value of `showPreviewPanelText` >> property to **TRUE** for GTK L&F. > > Abhishek Kumar has updated the pull request incrementally with two additional > commits since the last revision: > > - typo > - comment added for the GTK property test/jdk/javax/swing/JColorChooser/Test6977726.java line 65: > 63: // which is set to "Boolean.FALSE" for GTK L&F. Test instructions > are > 64: // modified to reflet that "Preview" title is not applicable for > GTK L&F. > 65: better to put it below l46 only.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20104#discussion_r1689280049
