On Wed, 4 Sep 2024 14:50:58 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Ravi Gupta has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8333403: Review comments fixed > > test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67: > >> 65: private static volatile Dimension compSize; >> 66: private static final java.util.Collection<ComponentEvent> events = >> 67: Collections.synchronizedList(new ArrayList<ComponentEvent>()); > > Suggestion: > > private static final Collection<ComponentEvent> events = > Collections.synchronizedList(new ArrayList<>()); removed events list , now events are printed using the ComponentListener. > test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 67: > >> 65: private static volatile Dimension compSize; >> 66: private static final java.util.Collection<ComponentEvent> events = >> 67: Collections.synchronizedList(new ArrayList<ComponentEvent>()); > > Any reason why you use fully qualified `java.util.Collection` class name > instead of importing it? removed events list , now events are printed using the ComponentListener. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763526359 PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1763526784
