On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> It has become quite common to use the following code > > > .rows((int) INSTRUCTIONS.lines().count() + 1) > > > to set the number of rows for `PassFailJFrame`. > > Make this the default value. Newer tests could drop `.rows` from builder > configuration if the new default works well. > > If a test needs customising the new default value, the newly added method > `rowsAdd` could be used to increase the number of rows. LGTM, eliminates the need to specify `.rows((int) INSTRUCTIONS.lines().count() + 1)` if the default no. of rows works for the test. ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21039#pullrequestreview-2310432394
