On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> It has become quite common to use the following code > > > .rows((int) INSTRUCTIONS.lines().count() + 1) > > > to set the number of rows for `PassFailJFrame`. > > Make this the default value. Newer tests could drop `.rows` from builder > configuration if the new default works well. > > If a test needs customising the new default value, the newly added method > `rowsAdd` could be used to increase the number of rows. This pull request has now been integrated. Changeset: d1d82400 Author: Alexey Ivanov <aiva...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/d1d824008d1dc70029013820814fd03c40b4e309 Stats: 35 lines in 1 file changed: 34 ins; 0 del; 1 mod 8340308: PassFailJFrame: Make rows default to number of lines in instructions Reviewed-by: honkar, azvegint ------------- PR: https://git.openjdk.org/jdk/pull/21039
