On Wed, 25 Sep 2024 10:39:09 GMT, Alexey Ivanov <[email protected]> wrote:
>> I added description to all the constructors available in `PassFailJFrame`. >> >> I generated the javadoc for it: [`PassFailJFrame` constructor >> details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html#constructor-detail) >> which is easier to read. This hosted javadoc could be used as a reference >> to its API. >> >> The constructor with the largest number of parameters contains a short >> description of how to use the `PassFailJFrame` object. >> >> Shall we deprecate the constructors in favour of `Builder`? >> >> The builder provides a more streamlined experience, therefore new tests >> should use it instead of constructors. We may update the tests which use the >> constructors, after which the constructors can be removed. > > Alexey Ivanov has updated the pull request incrementally with two additional > commits since the last revision: > > - Takes screenshots... > - disposing of -> disposal Marked as reviewed by prr (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21145#pullrequestreview-2329520645
