On Wed, 25 Sep 2024 07:19:09 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master
>> - problemlist updated
>> - eof newline
>> - checkbox tests
>
> test/jdk/ProblemList.txt line 797:
>
>> 795: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all
>> 796: java/awt/Checkbox/CheckboxIndicatorSizeTest.java 8340870 windows-all
>> 797: java/awt/Checkbox/CheckboxBoxSizeTest.java 8340870 windows-all
>
> duplicate addition CheckboxBoxSizeTest
Good catch. Updated.
> test/jdk/java/awt/Checkbox/CheckboxPreferredSizeTest.java line 58:
>
>> 56:
>> 57: private static Frame createAndShowUI() {
>> 58: StrangeCheckbox cbox = new StrangeCheckbox();
>
> I guess we can bring in the code in the StrangeCheckbox constructor and
> remove that class altogether as it's not doing anything particular rather
> than implicitly creating a Frame..
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777537647
PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1777537841
