On Thu, 26 Sep 2024 18:24:23 GMT, Harshitha Onkar <[email protected]> wrote:
>> test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65: >> >>> 63: Verify that all indicators of checkboxes has the same size. >>> 64: Verify that all indicators of radio buttons has the same >>> size. >>> 65: Press PASS if the above conditions are true else Press FAIL. >> >> I guess "Same size" is not correct here...I guess what we meant is the size >> should be proportionate to scaling or "size will change if font size is >> changed", it seems the size does not increase if we increase the scale.. >> but it still remains the "same", so some tester can consider it pass > > @prsadhuk I have a clarification about this: > Does the checkbox size depend on label size (font size) and they need to be > scaled proportionately or is the checkbox and indicator size dependent only > on uiScale? One is global setting and the other local..and local would get affected by global setting ie Checkboz size should be proportionate to local label fontsize and when we up the global uiScale, it would also increase the label font implicitly which then would affect checkbox size ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21094#discussion_r1778004732
