On Wed, 25 Sep 2024 07:20:21 GMT, Tejesh R <[email protected]> wrote:
> Open source these AWT Mouse tests:
>
> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java
> java/awt/Dialog/FileDialogWrongNameCrash.java
> java/awt/Dialog/DialogResizeTest.java
> java/awt/Dialog/GetLocationTest_1.java
> java/awt/Dialog/DialogIconTest/DialogIconTest.java
test/jdk/java/awt/Dialog/DialogResizeTest.java line 133:
> 131: public void componentHidden(ComponentEvent e) {
> 132: System.out.println("componentHidden event occurred.");
> 133: }
I guess PassFailJFrame.log would be of more use than System println, if at all
these logs are of any help..
test/jdk/java/awt/Dialog/FileDialogWrongNameCrash.java line 58:
> 56:
> 57: private static Frame initialize() {
> 58: Frame frame = new Frame("Frame");
give more meaningful name
test/jdk/java/awt/Dialog/GetLocationTest_1.java line 50:
> 48: up with the top left by the cursor
> 49: 2. If you see this correct behavior press PASS. If you
> see that
> 50: the yellow window is offset by an inset (5, 24) press
> FAIL
how will tester knows that the inset is of this dimension, it might vary from
platform to platform and also vary with different scaling? maybe just delete
this hardcoded dimension?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778177853
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778188170
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778189364
